Skip to content

Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsController#1735

Merged
montelaidev merged 9 commits intomainfrom
bump/deps-accounts-controller-27092023
Oct 12, 2023
Merged

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Sep 27, 2023 •
edited
Loading

Explanation

Bumps the following dependencies in the AccountsController and fixes a type error introduced by a using the latest snaps controller

Changelog

@metamask/accounts-controller

  • CHANGED:
  • @metamask/eth-snap-keyring updated to ^1.0.0
  • @metamask/keyring-api updated to ^1.0.0
  • @metamask/snaps-controllers updated to ^2.0.1
  • @metamask/snaps-utils updated to ^2.0.1
  • Changed eth-rpc-errors to @metamask/rpc-errors

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@montelaidev montelaidev requested a review from a team as a code owner September 27, 2023 15:42
@socket-security
Copy link

socket-security bot commented Sep 27, 2023 •
edited
Loading

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/snaps-utils 3.0.0 filesystem, shell +16 2.44 MB metamaskbot
@metamask/eth-snap-keyring 1.0.0 None +30 17.1 MB metamaskbot
@metamask/snaps-controllers 1.0.1...3.0.0 shell +26/-0 15.5 MB metamaskbot
@metamask/keyring-api 0.2.5...1.0.0 None +28/-34 16.8 MB metamaskbot

@socket-security
Copy link

socket-security bot commented Sep 27, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: validate-npm-package-name@5.0.0, @metamask/snaps-controllers@3.0.0, @metamask/snaps-utils@3.0.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@montelaidev montelaidev force-pushed the bump/deps-accounts-controller-27092023 branch from bff8e0a to 904f204 Compare September 27, 2023 15:48
@montelaidev
Copy link
Contributor Author

montelaidev commented Sep 27, 2023

@SocketSecurity ignore @metamask/snaps-controllers@2.0.1
@SocketSecurity ignore @metamask/snaps-utils@2.0.1

legobeat

This comment was marked as outdated.

Sign in to view

@legobeat legobeat self-requested a review September 27, 2023 23:19
legobeat
legobeat reviewed Sep 27, 2023
View reviewed changes
legobeat
legobeat reviewed Sep 27, 2023
View reviewed changes
legobeat

This comment was marked as resolved.

Sign in to view

@montelaidev montelaidev changed the title Bump/deps accounts controller 27092023 Bump/deps accounts controller 04102023 Oct 4, 2023
@montelaidev montelaidev changed the title Bump/deps accounts controller 04102023 Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsController 04102023 Oct 4, 2023
@legobeat legobeat changed the title Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsController 04102023 Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsController Oct 4, 2023
@legobeat legobeat dismissed their stale review October 4, 2023 00:59

synced with main and conflicts resolved

@legobeat legobeat requested a review from a team October 4, 2023 01:00
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 4, 2023
Mrtenz
Mrtenz previously approved these changes Oct 4, 2023
View reviewed changes
@legobeat
Copy link
Contributor

legobeat commented Oct 4, 2023 

@SocketSecurity ignore validate-npm-package-name@5.0.0

new author ok

@montelaidev
Copy link
Contributor Author

montelaidev commented Oct 12, 2023

@SocketSecurity ignore @metamask/snaps-controllers@3.0.0
@SocketSecurity ignore @metamask/snaps-utils@3.0.0

montelaidev
montelaidev commented Oct 12, 2023
View reviewed changes
packages/accounts-controller/tsconfig.build.json
"outDir": "./dist",
"rootDir": "./src"
"rootDir": "./src",
"skipLibCheck": true
Copy link
Contributor Author

@montelaidev montelaidev Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring type errors from @metamask/rpc-methods

node_modules/@metamask/rpc-methods/dist/types/restricted/getLocale.d.ts:46:113 - error TS2344: Type 'void' does not satisfy the constraint 'RestrictedMethodParameters | null'.

export declare function getImplementation({ getLocale }: GetLocaleMethodHooks): (_args: RestrictedMethodOptions<void>) => Promise<string>;

Will revert once it is fixed

@montelaidev montelaidev merged commit 8f9ca28 into main Oct 12, 2023
@montelaidev montelaidev deleted the bump/deps-accounts-controller-27092023 branch October 12, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danroc danroc danroc approved these changes

@Mrtenz Mrtenz Mrtenz left review comments

@legobeat legobeat Awaiting requested review from legobeat

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@montelaidev @legobeat @Mrtenz @danroc